8000 Adds Script System for adding paths to redscript compilation (REDmod compatible) by jackhumbert · Pull Request #21 · wopss/RED4ext · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adds Script System for adding paths to redscript compilation (REDmod compatible) #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
May 9, 2023
Merged

Adds Script System for adding paths to redscript compilation (REDmod compatible) #21

merged 22 commits into from
May 9, 2023

Conversation

jackhumbert
Copy link
Contributor
@jackhumbert jackhumbert commented Apr 29, 2023 •
edited
Loading

Paths can be added via the Scripts::Add function in the sdk, during Load:

aSdk->scripts->Add(aHandle, L"module.reds");

Paths can either directories or files (handled by scc), relative to the plugin's folder, or absolute (mainly for testing/development).

This will also force script compilation when REDmods are enabled, which will cause double-compilation if cybercmd is installed - cybercmd is no longer needed for this scenario.

wopss
wopss requested changes Apr 30, 2023
View reviewed changes
Copy link
Owner
@wopss wopss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have some remarks and questions 🏃

wopss
wopss requested changes May 8, 2023
View reviewed changes
Copy link
Owner
@wopss wopss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more remarks 🏃

jackhumbert and others added 2 commits May 8, 2023 15:34
@jackhumbert @wopss
Update src/dll/Hooks/InitScripts.cpp
3653916 
Co-authored-by: Octavian Dima <3403191+WopsS@users.noreply.github.com>
@jackhumbert
changes from review
8a2f8cc
@jackhumbert
Copy link
Contributor Author

Will this require an increment to the SDK version? Trying to figure out to specify that this functionality is needed on the plugin-side.

@wopss
Copy link
Owner
wopss commented May 9, 2023

We increase the API version, but still supports 0.3.0 since it is backwards compatible.

wopss
wopss requested changes May 9, 2023
View reviewed changes
@wopss
Copy link
Owner
wopss commented May 9, 2023

Before merging this, we need a PR for the SDK.

jackhumbert and others added 2 commits May 9, 2023 13:17
@jackhumbert @wopss
Apply suggestions from code review
9926440 
Co-authored-by: Octavian Dima <3403191+WopsS@users.noreply.github.com>
@jackhumbert
fix-up changes from review
47e4059
@jackhumbert jackhumbert mentioned this pull request May 9, 2023
Merged
@wopss wopss merged commit 4b71b23 into wopss:master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psiberx psiberx psiberx left review comments

@wopss wopss wopss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackhumbert @wopss @psiberx
0