8000 Node/Solana: Shim watcher cleanup by bruce-riley · Pull Request #4269 · wormhole-foundation/wormhole · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Node/Solana: Shim watcher cleanup #4269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 17, 2025
Merged

Node/Solana: Shim watcher cleanup #4269

merged 2 commits into from
Mar 17, 2025

Conversation

bruce-riley
Copy link
Contributor

No description provided.

@bruce-riley bruce-riley force-pushed the node/solana_shim_watcher_cleanup branch from 3a90296 to 6595ed9 Compare February 18, 2025 17:43 8000
@bruce-riley bruce-riley force-pushed the node/solana_shim_watcher_cleanup branch from 6595ed9 to 311656f Compare February 26, 2025 14:45
@bruce-riley bruce-riley marked this pull request as ready for review February 26, 2025 15:04
panoel
panoel previously approved these changes Mar 3, 2025
View reviewed changes
@bruce-riley bruce-riley force-pushed the node/solana_shim_watcher_cleanup branch from 311656f to 8e21228 Compare March 3, 2025 15:19
johnsaigle
johnsaigle reviewed Mar 6, 2025
View reviewed changes
Copy link
Contributor
@johnsaigle johnsaigle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of the error handling is a little too general and may cause some bugs down the line. Otherwise, I made some suggestions to improve error messages and fix typos in test names.

banescusebi
banescusebi reviewed Mar 7, 2025
View reviewed changes
@bruce-riley bruce-riley force-pushed the node/solana_shim_watcher_cleanup branch from 9f9c489 to f2df626 Compare March 10, 2025 17:12
johnsaigle
johnsaigle approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor
@johnsaigle johnsaigle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating the changes!

@bruce-riley bruce-riley requested a review from banescusebi March 11, 2025 13:23
@bruce-riley bruce-riley force-pushed the node/solana_shim_watcher_cleanup branch from f2df626 to 0d296ab Compare March 14, 2025 17:43
banescusebi
banescusebi approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor
@banescusebi banescusebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bruce-riley bruce-riley requested a review from panoel March 17, 2025 13:57
@bruce-riley bruce-riley merged commit 4e4eaa6 into wormhole-foundation:main Mar 17, 2025
31 checks passed
@bruce-riley bruce-riley deleted the node/solana_shim_watcher_cleanup branch March 17, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banescusebi banescusebi banescusebi approved these changes

@johnsaigle johnsaigle johnsaigle approved these changes

@panoel panoel panoel approved these changes

@evan-gray evan-gray Awaiting requested review from evan-gray evan-gray is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bruce-riley @banescusebi @johnsaigle @panoel
0