8000 txverifier: fix bugs and improve error handling by johnsaigle · Pull Request #4277 · wormhole-foundation/wormhole · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

txverifier: fix bugs and improve error handling #4277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 26, 2025
Merged

txverifier: fix bugs and improve error handling #4277

merged 4 commits into from
Feb 26, 2025

Conversation

johnsaigle
Copy link
Contributor
@johnsaigle johnsaigle commented Feb 24, 2025 •
edited
Loading
  • Sometimes From can be set to the zero address when a token is minted. This restriction has been removed
  • Made error handling around irrelevant receipts less noisy. Now there will not be any WARN logs when a receipt contains a LogMessagePublished event that was sent by someone other than the token bridge.
  • Changed functions that process receipts to always return nil rather than the empty struct
  • Added more unit tests to ensure that functions don't panic in nil input
  • Added Validation function for TransferReceipts
  • Add README for running the Transfer Verifier CLI tool
  • Fix typo in variable name

@johnsaigle johnsaigle added bug Something isn't working node labels Feb 24, 2025
@johnsaigle johnsaigle marked this pull request as ready for review February 24, 2025 20:56
@johnsaigle johnsaigle mentioned this pull request Feb 24, 2025
Merged
2 tasks
@johnsaigle johnsaigle requested a review from pleasew8t February 24, 2025 20:57
pleasew8t
pleasew8t reviewed Feb 25, 2025
View reviewed changes
pleasew8t
pleasew8t reviewed Feb 25, 2025
View reviewed changes
@johnsaigle johnsaigle requested a review from pleasew8t February 25, 2025 14:51
pleasew8t
pleasew8t previously approved these changes Feb 25, 2025
View reviewed changes
@johnsaigle
txverifier: fix bugs and improve error handling
b561d0f 
- Sometimes From _can_ be set to the zero address when a token is
  minted. This restriction has been removed
- Made error handling around irrelevant receipts less noisy. Now there
  will not be any WARN logs when a receipt contains a
  LogMessagePublished event that was sent by someone other than the
  token bridge.
- Changed functions that process receipts to always return nil rather
  than the empty struct
- Added more unit tests to ensure that functions don't panic in nil
  input
- Added Validation function for TransferReceipts
- Add README for running the Transfer Verifier CLI tool
- Fix typo in variable name
@johnsaigle
Add txverifier to cspell
7fda916
@johnsaigle
Explicitly check err messages for Validate; fix typo
b3dff93
bruce-riley
bruce-riley reviewed Feb 25, 2025
View reviewed changes
bruce-riley
bruce-riley previously approved these changes Feb 25, 2025
View reviewed changes
@johnsaigle johnsaigle dismissed stale reviews from bruce-riley and pleasew8t via 45ccf9b February 25, 2025 16:55
evan-gray
evan-gray approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor
@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only reviewed cspell-custom-words.txt changes

@johnsaigle johnsaigle merged commit 8a69ffd into wormhole-foundation:main Feb 26, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleasew8t pleasew8t pleasew8t approved these changes

@evan-gray evan-gray evan-gray approved these changes

@bruce-riley bruce-riley bruce-riley approved these changes

@panoel panoel Awaiting requested review from panoel

@SEJeff SEJeff Awaiting requested review from SEJeff

Assignees
No one assigned
Labels
bug Something isn't working node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johnsaigle @pleasew8t @evan-gray @bruce-riley
0