8000 Update elliptic to >= 6.6.1 by kev1n-peters · Pull Request #4272 · wormhole-foundation/wormhole · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update elliptic to >= 6.6.1 #4272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 27, 2025
Merged

Update elliptic to >= 6.6.1 #4272

merged 2 commits into from
Feb 27, 2025

Conversation

kev1n-peters
Copy link
Contributor

johnsaigle
johnsaigle previously approved these changes Feb 20, 2025
View reviewed changes
@kev1n-peters
Copy link
Contributor Author

I ran this script to update all of the elliptic dependencies:

const fs = require('fs');
const path = require('path');
const { execSync } = require('child_process');

const targetVersion = '^6.6.1';
const targetDependency = 'elliptic';

function updatePackageJson(filePath) {
  const packageJson = JSON.parse(fs.readFileSync(filePath, 'utf8'));

  let updated = false;

  // Update the version of elliptic in dependencies
  if (packageJson.dependencies && packageJson.dependencies[targetDependency]) {
    packageJson.dependencies[targetDependency] = targetVersion;
    updated = true;
  }

  // Update the version of elliptic in devDependencies
  if (packageJson.devDependencies && packageJson.devDependencies[targetDependency]) {
    packageJson.devDependencies[targetDependency] = targetVersion;
    updated = true;
  }

  // Add or update elliptic in overrides
  if (!packageJson.overrides) {
    packageJson.overrides = {};
  }
  if (packageJson.overrides[targetDependency] !== targetVersion) {
    packageJson.overrides[targetDependency] = targetVersion;
    updated = true;
  }

  if (updated) {
    fs.writeFileSync(filePath, JSON.stringify(packageJson, null, 2));
    console.log(`Updated ${filePath}`);

    // Run npm install in the directory of the updated package.json
    const dir = path.dirname(filePath);
    console.log(`Running npm install in ${dir}`);
    execSync('npm install', { cwd: dir, stdio: 'inherit' });
  }
}

function findPackageJsonFiles(dir) {
  const files = fs.readdirSync(dir);

  files.forEach((file) => {
    const filePath = path.join(dir, file);
    const stat = fs.statSync(filePath);

    if (stat.isDirectory() && file !== 'node_modules') {
      findPackageJsonFiles(filePath);
    } else if (file === 'package.json') {
      updatePackageJson(filePath);
    }
  });
}

// Start the search from the current directory
findPackageJsonFiles(process
8000
.cwd());

evan-gray
evan-gray approved these changes Feb 22, 2025
View reviewed changes
Copy link
Contributor
@evan-gray evan-gray left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at a glance, the change / approach seem reasonable to me. also noting that many, if not all, of these packages / use cases are non-production and/or controlled inputs

djb15
djb15 approved these changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator
@djb15 djb15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat script! Thanks for updating

@johnsaigle johnsaigle merged commit e90146b into main Feb 27, 2025
31 checks passed
@johnsaigle johnsaigle deleted the update-elliptic branch February 27, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcsongor kcsongor kcsongor approved these changes

@johnsaigle johnsaigle johnsaigle approved these changes

@a5-pickle a5-pickle a5-pickle approved these changes

@djb15 djb15 djb15 approved these changes

@nonergodic nonergodic nonergodic approved these changes

@gator-boi gator-boi gator-boi approved these changes

@evan-gray evan-gray evan-gray approved these changes

@panoel panoel Awaiting requested review from panoel panoel is a code owner

@bruce-riley bruce-riley Awaiting requested review from bruce-riley bruce-riley is a code owner

@SEJeff SEJeff Awaiting requested review from SEJeff SEJeff is a code owner

@mdulin2 mdulin2 Awaiting requested review from mdulin2 mdulin2 is a code owner

@pleasew8t pleasew8t Awaiting requested review from pleasew8t pleasew8t is a code owner

@nik-suri nik-suri Awaiting requested review from nik-suri nik-suri is a code owner

@joelsmith-2019 joelsmith-2019 Awaiting requested review from joelsmith-2019 joelsmith-2019 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kev1n-peters @kcsongor @johnsaigle @a5-pickle @djb15 @nonergodic @gator-boi @evan-gray
0