txverifier: Increase integration test coverage and simplify Tilt set-up #4280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- Add integration test case for Transfer Tokens (in addition to existing test for 'Transfer Tokens With Payload')
- Refactor integration test set-up. Now there is only one YAML file to manage instead of two. The tests have also been expanded to check for a variable number of error strings and include a timeout. They also report an error if too many error strings are found.
- The Tilt configuration now runs this test as a Job rather than a Deployment. This is more appropriate for a test that is meant to run once.
8adbb75 to
9253c2c
Compare
2 tasks
5f213cd to
c2312f4
Compare
bruce-riley
previously approved these changes
Mar 7, 2025
pleasew8t
previously approved these changes
Mar 10, 2025
evan-gray
requested changes
Mar 13, 2025
evan-gray
previously approved these changes
Mar 13, 2025
evan-gray
reviewed
Mar 13, 2025
evan-gray
approved these changes
Mar 13, 2025
9412c32 to
c2911af
Compare
c2911af to
eb84228
Compare
- Add integration test case for Transfer Tokens (in addition to existing Transfer Tokens With Payload' - Refactor integration test set-up. Now there is only one YAML file to manage instead of two. The tests have also been expanded to check for a variable number of error strings and include a timeout. They also report an error if too many error strings are found. - The Tilt configuration now runs this test as a Job rather than a Deployment. This is more appropriate for a test that is meant to run once.
- Adds an exception for the guardiand docker image used by tx-verifier integration testing - Fixes various shellcheck errors in the script 1. egrep is deprecated 2. checking $? is redundant 3. regex "Dockerfile*" was being used as a glob
Co-authored-by: Evan Gray <56235822+evan-gray@users.noreply.github.com>
eb84228 to
27a5d36
Compare
|
Looks like a good change. Isolates the testing to the tx-verifier location more and has a failure case for multiple transfers. |
mdulin2
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.