-
Notifications
You must be signed in to change notification settings - Fork 778
Node/EVM: Add contract address to chain config #4299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bruce-riley
merged 1 commit into
wormhole-foundation:main
from
wormholelabs-xyz:node/evm_add_contract_addr_to_chain_config
Mar 21, 2025
Merged
Node/EVM: Add contract address to chain config #4299
bruce-riley
merged 1 commit into
wormhole-foundation:main
from
wormholelabs-xyz:node/evm_add_contract_addr_to_chain_config
Mar 21, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here is the latest output from the verify tool.
|
6169ee4
to
f5049f0
Compare
ec21049
to
7d04908
Compare
7d04908
to
79f3d1f
Compare
evan-gray
approved these changes
Mar 21, 2025
evan-gray
reviewed
Mar 21, 2025
panoel
reviewed
Mar 21, 2025
panoel
reviewed
Mar 21, 2025
panoel
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the EVM chain config to include the core contract address. This provides easy access to the contract addresses and also allows the
verify_chain_config
to confirm that the contract exists at the expected location. This PR also enhances the tool to make it easier to see what it is doing.Note that, although it would be possible to use these contract addresses as defaults for the guardian, we are not doing that at this time since it could make it easier for an attacker to compromise the watchers.
Note, while working on this PR, I realized that Linea was currently allowed in mainnet when it should not be, so I fixed that.
Note to reviewers: If you trust the verify tool, you don't need to worry about validating the contract addresses. . .