ci: Add nolintlint to golangci-lint #4346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
reviewed
Apr 10, 2025
bruce-riley
reviewed
Apr 10, 2025
bruce-riley
previously approved these changes
Apr 10, 2025
bruce-riley
previously approved these changes
Apr 14, 2025
djb15
reviewed
Apr 14, 2025
djb15
approved these changes
Apr 14, 2025
bruce-riley
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existi
2CCE
ng code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://golangci-lint.run/usage/linters/#nolintlint
Configuration:
nolintdirectives need a reasonThis PR was created by adding the linter and then running
golangci-lint run --fix. Then I went in and added manual comments where necessary.In a few cases I added TODO comments where the lint seemed correct. The idea is to limit the scope of this PR is to add the new linter, not to refactor existing code.