8000 deps: Remove miguelmota/go-ethereum-hdwallet; delete unused code by johnsaigle · Pull Request #4347 · wormhole-foundation/wormhole · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

deps: Remove miguelmota/go-ethereum-hdwallet; delete unused code #4347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2025
Merged

deps: Remove miguelmota/go-ethereum-hdwallet; delete unused code #4347

merged 2 commits into from
Apr 17, 2025

Conversation

johnsaigle
Copy link
Contributor
  • Remove the pkg/devnet/constants.go file which was largely unused. Most of this code has also not been updated in a long time, and it refers to both Ganache and Truffle where we now use Foundry for testing.
  • Move the "Ganache" constant to the new devnet constants file under SDK
  • Delete the rest of the unused code
  • Ran go mod tidy and committed the results, which removed one direct dependency and a couple of indirect ones

@johnsaigle johnsaigle added sdk dependencies Pull requests that update a dependency file labels Apr 10, 2025
@johnsaigle johnsaigle marked this pull request as ready for review April 11, 2025 18:29
bruce-riley
bruce-riley previously approved these changes Apr 14, 2025
View reviewed changes
@johnsaigle johnsaigle force-pushed the delete-dep-hdwallet branch from 63423d1 to 0f43127 Compare April 14, 2025 15:29
djb15
djb15 approved these changes Apr 14, 2025
View reviewed changes
@johnsaigle johnsaigle force-pushed the delete-dep-hdwallet branch from 62cb6ab to 3c7b170 Compare April 14, 2025 20:57
@johnsaigle
deps: Remove miguelmota/go-ethereum-hdwallet; delete unused code
2383542 
- Remove the pkg/devnet/constants.go file which was largely unused. Most
  of this code has also not been updated in a long time, and it refers
  to both Ganache and Truffle where we now use Foundry for testing.
- Move the "Ganache" constant to the new devnet constants file under
  SDK
- Delete the rest of the unused code
- Ran `go mod tidy` and committed the results, which removed one direct
  dependency and a couple of indirect ones
@johnsaigle
change format of new SDK constant
44475a1
@johnsaigle johnsaigle force-pushed the delete-dep-hdwallet branch from 3c7b170 to 44475a1 Compare April 16, 2025 14:39
@johnsaigle johnsaigle requested a review from bruce-riley April 16, 2025 14:39
@johnsaigle johnsaigle merged commit 6c0177b into wormhole-foundation:main Apr 17, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djb15 djb15 djb15 approved these changes

@bruce-riley bruce-riley bruce-riley approved these changes

@panoel panoel Awaiting requested review from panoel panoel is a code owner

@evan-gray evan-gray Awaiting requested review from evan-gray evan-gray is a code owner

@SEJeff SEJeff Awaiting requested review from SEJeff SEJeff is a code owner

@kev1n-peters kev1n-peters Awaiting requested review from kev1n-peters kev1n-peters is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file sdk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnsaigle @djb15 @bruce-riley
0