8000 Node/Solana: Minor watcher cleanup by bruce-riley · Pull Request #4348 · wormhole-foundation/wormhole · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Node/Solana: Minor watcher cleanup #4348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 15, 2025
Merged

Node/Solana: Minor watcher cleanup #4348

merged 3 commits into from
Apr 15, 2025

Conversation

bruce-riley
Copy link
Contributor
@bruce-riley bruce-riley commented Apr 11, 2025 •
edited
Loading

This PR does some minor clean up of the Solana watcher. Notably:

  • Optimizes the check to see if a transaction might include a wormhole PostMessage
  • Can't save the ctx across a restart since it may have previously been canceled
  • Removes logging of the commitment level since it is in the logger name
  • Cleans up various other log messages
  • A few other minor things
  • Don't count the wrong commitment level as an observation

@bruce-riley bruce-riley force-pushed the node/solana_minor_cleanup branch from 4d6ef31 to 76c01aa Compare April 11, 2025 16:03
@bruce-riley bruce-riley changed the title Node/Solana: Minor cleanup Node/Solana: Minor watcher cleanup Apr 11, 2025
@bruce-riley bruce-riley marked this pull request as ready for review April 11, 2025 16:35
@bruce-riley bruce-riley force-pushed the node/solana_minor_cleanup branch from 76c01aa to d2d1772 Compare April 11, 2025 16:49
@bruce-riley bruce-riley force-pushed the node/solana_minor_cleanup branch from d2d1772 to addf129 Compare April 11, 2025 16:52
evan-gray
evan-gray previously approved these changes Apr 14, 2025
View reviewed changes
@bruce-riley bruce-riley requested a review from evan-gray April 14, 2025 15:31
panoel
panoel previously approved these changes Apr 14, 2025
View reviewed changes
@bruce-riley bruce-riley requested a review from panoel April 14, 2025 19:36
@bruce-riley bruce-riley merged commit 5d368eb into wormhole-foundation:main Apr 15, 2025
31 checks passed
@bruce-riley bruce-riley deleted the node/solana_minor_cleanup branch April 15, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panoel panoel panoel approved these changes

@evan-gray evan-gray evan-gray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bruce-riley @panoel @evan-gray
0