8000 sdk: Return false for empty arguments to VerifySignatures by johnsaigle · Pull Request #4340 · wormhole-foundation/wormhole · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

sdk: Return false for empty arguments to VerifySignatures #4340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

sdk: Return false for empty arguments to VerifySignatures #4340

merged 1 commit into from
Apr 14, 2025
+21 −9

Conversation

johnsaigle
Copy link
Contributor
  • Updates SDK function and unit tests to return false for the empty case. This is to prevent the function returning true trivially for empty arguments. Either true or false may be 'correct', but returning false is less likely to lead to failing open if empty arguments are passed by mistake.
  • Adds a comment warning that VerifySignatures is the wrong function to use when actually validating a VAA. (This is a bug that has occurred before but was caught in internal review.)

@johnsaigle johnsaigle marked this pull request as ready for review April 10, 2025 15:31
@johnsaigle
sdk: Return false for empty arguments to VerifySignatures
2d2be75 
- Updates SDK function and unit tests to return false for the empty
  case. This is to prevent the function returning true trivially for
  empty arguments. Either true or false may be 'correct', but returning
  false is less likely to lead to failing open if empty arguments are
  passed by mistake.
- Adds a comment warning that VerifySignatures is the wrong function to
  use when actually validating a VAA. (This is a bug that has occurred
  before but was caught in internal review.)
- Modifies a unit test case that was calling VerifySignatures twice per
  run.
@johnsaigle johnsaigle force-pushed the verify-sigs-false-empty branch from 4cd4337 to 2d2be75 Compare April 14, 2025 15:30
@johnsaigle johnsaigle merged commit 2999ee8 into wormhole-foundation:main Apr 14, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleasew8t pleasew8t pleasew8t approved these changes

@bruce-riley bruce-riley bruce-riley approved these changes

@evan-gray evan-gray Awaiting requested review from evan-gray evan-gray is a code owner

@panoel panoel Awaiting requested review from panoel panoel is a code owner

@SEJeff SEJeff Awaiting requested review from SEJeff SEJeff is a code owner

Assignees
No one assigned
Labels
sdk test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnsaigle @pleasew8t @bruce-riley
0