8000 ci: add golangci-lint linters with no violations by johnsaigle · Pull Request #4341 · wormhole-foundation/wormhole · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ci: add golangci-lint linters with no violations #4341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

ci: add golangci-lint linters with no violations #4341

merged 1 commit into from
Apr 11, 2025

Conversation

johnsaigle
Copy link
Contributor
@johnsaigle johnsaigle commented Apr 10, 2025 •
edited
Loading

Rework of #4307 after the major version upgrade for golangci-lint.

The rules have also been sorted alphabetically.

@johnsaigle johnsaigle changed the title lint: add linters with no existing violations lint: add linters with no violations Apr 10, 2025
@johnsaigle johnsaigle requested a review from mdulin2 April 10, 2025 16:22
@johnsaigle johnsaigle marked this pull request as ready for review April 10, 2025 16:22
@johnsaigle johnsaigle added the ci label Apr 10, 2025
@johnsaigle johnsaigle changed the title lint: add linters with no violations ci: add golangci-lint linters with no violations Apr 10, 2025
mdulin2
mdulin2 approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor
@mdulin2 mdulin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these seem like good practices!

Given that CI still passed when you added these with no additional changes, they seem like things to avoid and not prone to false positives.

@johnsaigle johnsaigle merged commit 115a43e into wormhole-foundation:main Apr 11, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djb15 djb15 djb15 approved these changes

@mdulin2 mdulin2 mdulin2 approved these changes

@evan-gray evan-gray Awaiting requested review from evan-gray evan-gray is a code owner

Assignees
No one assigned
Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnsaigle @djb15 @mdulin2
0