feat(queries): ratelimits #4359
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
queryratelimit.Enforcer is in charge of storing rate limits and responding based off a policy
queryratelimit.PolicyProvider is in charge of providing policies, aka fetching from chain/config, cache, etc
i have implemented a policyprovider which uses ccqAllowedRequesters. we can test using this, the functionality should be similar, except that there is a rate limit now.
we could also read from a json file of map[common.Address]*Policy. it is trivial to write a policyproviderfetcher that would work based off this.
in the future we will write a policyprovider which will request the policies from chain for a given key
dependencies:
adds x/sync from a transitive -> direct dependency, for singleflight.
adds github.com/google/btree from a transitive -> direct dependency, for a sorted map implementation.