8000 node/admin: add template for core bridge set message by fergarrui · Pull Request #4369 · wormhole-foundation/wormhole · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

node/admin: add template for core bridge set message #4369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 21, 2025
Merged

node/admin: add template for core bridge set message #4369

merged 14 commits into from
May 21, 2025

Conversation

fergarrui
Copy link
Member
@fergarrui fergarrui commented May 2, 2025 •
edited
Loading

A new template command has been added:

message CoreBridgeSetMessageFee {
  // ID of the chain of the core bridge contract where the message fee should be updated (uint16).
  uint32 chain_id = 1;
  // New message fee.
  uint64 message_fee = 2;
}

8000
@fergarrui fergarrui changed the title node/admin: add template for core bridge set message WIP: node/admin: add template for core bridge set message May 2, 2025
@fergarrui fergarrui changed the title WIP: node/admin: add template for core bridge set message node/admin: add template for core bridge set message May 2, 2025
bruce-riley
bruce-riley previously approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor
@bruce-riley bruce-riley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but don't you also need to update adminserver.go and sdk/vaa/payload.go?

@fergarrui
Copy link
Member Author

This looks good, but don't you also need to update adminserver.go and sdk/vaa/payload.go?

Updated both files, thank you @bruce-riley
Please let me know if I need to update any other file

@nik-suri nik-suri requested a review from bruce-riley May 5, 2025 16:22
johnsaigle
johnsaigle reviewed May 8, 2025
View reviewed changes
@nik-suri nik-suri requested a review from johnsaigle May 12, 2025 18:19
@fergarrui fergarrui force-pushed the guardiand/core-bridge-set-fee branch from f230c64 to dbc58e7 Compare May 14, 2025 11:35
bruce-riley
bruce-riley requested changes May 19, 2025
View reviewed changes
Copy link
Contributor
@bruce-riley bruce-riley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test in sdk/vaa/payloads_test.go.

@fergarrui
Copy link
Member Author

Please add a test in sdk/vaa/payloads_test.go.

Done, thanks!

@fergarrui fergarrui requested a review from bruce-riley May 20, 2025 15:18
@fergarrui fergarrui merged commit 5752197 into main May 21, 2025
33 checks passed
@fergarrui fergarrui deleted the guardiand/core-bridge-set-fee branch May 21, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsaigle johnsaigle johnsaigle approved these changes

@bruce-riley bruce-riley bruce-riley approved these changes

@panoel panoel Awaiting requested review from panoel panoel is a code owner

@evan-gray evan-gray Awaiting requested review from evan-gray evan-gray is a code owner

@SEJeff SEJeff Awaiting requested review from SEJeff 54C4 SEJeff is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fergarrui @johnsaigle @bruce-riley
0