node(governor): reobservations should not flow cancel #4375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we be checking these in other spots? I've listed two below but may be missing some others. If we don't check on the database reload if something was a reobservation or not then wouldn't this lead to more funds being flow-cancelled than it should be? On I think this would require us to modify the storage semantics of the transfer to include whether or not something was a reobservation though. Hmmm. |
|
Putting this on pause for now until we have a longer discussion about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reobservations are complicated to reason about in a context where flow cancel is enabled. Disabling reobservations is simpler, with only a minor downside that otherwise-eligible reobservations of token transfers will not flow cancel.