fix: remove redundant --contract-address parameter from worm submit command #4376
Conversation
|
Can you show an example of test output that shows that this is correct, as well as link to the contract address in the SDK? It would be good to also add test instructions so that someone can reproduce this. |
|
Hi @johnsaigle! Here's the proof that this change is correct: SDK automatically knows contract addressesThe SDK has built-in contract addresses for all chains. When you don't specify Test output showing SDK knows Aptos addresses: $ worm info contract testnet aptos Core
0x5bc11445584a763c1fa7ed39081f1b920954da14e04b32440cba863d03e19625Link to SDK codeThe SDK automatically resolves addresses here: contract = contract ?? contracts.coreBridge.get(network, chain);Before vs AfterBefore (redundant): worm submit $VAA --chain aptos --contract-address 0x5bc1... --network testnetAfter (simplified): worm submit --network testnet $VAA --chain aptosBoth commands do exactly the same thing - the SDK automatically finds the contract address. Test instructionscd clients/js
npm install && npm run build
node build/main.js info contract testnet aptos CoreThis change removes redundant code while maintaining identical functionality. |
Resolved a TODO comment in the Aptos upgrade script by removing the redundant --contract-address parameter from the worm submit command.
The SDK already knows the contract addresses for each chain and module, making the explicit parameter unnecessary.
Instead, the script now uses the --chain parameter to specify Aptos as the target chain, allowing the SDK to automatically resolve the correct contract address.
Changes: