8000 add Converge testnet by aapclark · Pull Request #4394 · wormhole-foundation/wormhole · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add Converge testnet #4394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

add Converge testnet #4394

merged 1 commit into from
Jun 10, 2025

Conversation

aapclark
Copy link
Contributor
@aapclark aapclark commented Jun 2, 2025 •
edited
Loading

  • add Converge to guardiand

  • add Converge network to sdk

  • add env from Converge testnent deployment

  • add converge testnet to js sdk

-- Wormhole Core Addresses --------------------------------------------------
| Setup address                | 0xCbA13Df0270Af08478c88B2799B00DB43D50071C |
| Implementation address       | 0xF549bEB2A1eaB781899d46003f36F6652B5B8eb4 |
| Wormhole address             | 0x556B259cFaCd9896B2773310080c7c3bcE90Ff01 |
-----------------------------------------------------------------------------

Verifying test converge...
   Verifying EVM chain ID for test converge ✓
   Verifying finality values for test converge ✓
   Verifying contract address for test converge ✓

bruce-riley
bruce-riley requested changes Jun 3, 2025
View reviewed changes
Copy link
Contributor
@bruce-riley bruce-riley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few tweaks.

Additionally, please add the output from this command to the PR description:

node/pkg/watchers/evm/verify_chain_config/$ go run verify.go --env testnet --chainId 53

@aapclark
Copy link
Contributor Author
aapclark commented Jun 3, 2025

Just a few tweaks.

Additionally, please add the output from this command to the PR description:

node/pkg/watchers/evm/verify_chain_config/$ go run verify.go --env testnet --chainId 53

I'll need to get in touch with someone at Converge as this command and a curl command to that RPC url indicate a missing certificate.

@aapclark aapclark force-pushed the converge-testnet branch from a7b815b to 15eaaa6 Compare June 4, 2025 19:24
@aapclark aapclark requested a review from bruce-riley June 4, 2025 19:46
bruce-riley
bruce-riley previously approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor
@bruce-riley bruce-riley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (assuming the checks pass). Thanks for making the changes!

evan-gray
evan-gray requested changes Jun 5, 2025
View reviewed changes
Copy link
Contributor
@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately, I believe you have made a configuration mistake that you cannot recover from and will need to redeploy the core contract.

@aapclark
add Converge testnet
e4ccbcf 
- add Converge to guardiand

- add Converge network to sdk

- add env from Converge testnent deployment

- add converge testnet to js sdk

```
-- Wormhole Core Addresses --------------------------------------------------
| Setup address                | 0xCbA13Df0270Af08478c88B2799B00DB43D50071C |
| Implementation address       | 0xF549bEB2A1eaB781899d46003f36F6652B5B8eb4 |
| Wormhole address             | 0x556B259cFaCd9896B2773310080c7c3bcE90Ff01 |
-----------------------------------------------------------------------------

Verifying test converge...
   Verifying EVM chain ID for test converge ✓
   Verifying finality values for test converge ✓
   Verifying contract address for test converge ✓
```

deploy with proper init signer
@aapclark aapclark force-pushed the converge-testnet branch from 15eaaa6 to e4ccbcf Compare June 5, 2025 20:55
@aapclark aapclark requested review from evan-gray and bruce-riley June 6, 2025 12:38
@evan-gray evan-gray merged commit 40ddcfe into wormhole-foundation:main Jun 10, 2025
33 checks passed
@aapclark aapclark deleted the converge-testnet branch June 13, 2025 14:37
@bruce-riley bruce-riley mentioned this pull request Jun 16, 2025
Merged
@johnsaigle johnsaigle mentioned this pull request Jun 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-gray evan-gray evan-gray approved these changes

@bruce-riley bruce-riley bruce-riley approved these changes

@panoel panoel Awaiting requested review from panoel panoel is a code owner

@SEJeff SEJeff Awaiting requested review from SEJeff SEJeff is a code owner

@kev1n-peters kev1n-peters Awaiting requested review from kev1n-peters

@a5-pickle a5-pickle Awaiting requested review from a5-pickle

@gator-boi gator-boi Awaiting requested review from gator-boi gator-boi is a code owner

@kcsongor kcsongor Awaiting requested review from kcsongor kcsongor is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aapclark @evan-gray @bruce-riley
0