Node: Specify config file #4404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53e8a99 to
639223e
Compare
johnsaigle
previously approved these changes
Jun 19, 2025
fc534d9 to
e95f6de
Compare
panoel
reviewed
Jun 19, 2025
panoel
previously approved these changes
Jun 19, 2025
johnsaigle
previously approved these changes
Jun 20, 2025
evan-gray
previously approved these changes
Jun 23, 2025
d199332
a3d47c2 to
34d0e0f
Compare
34d0e0f to
83ed634
Compare
johnsaigle
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows a guardian operator to load config parameters from an arbitrary config file when running
guardiand nodeby specifying the--config <fname>command line argument. This file may be in any of the formats supported by Viper, including .yaml and .json.Parameters from this file are loaded first, then overridden by environment variables starting with
GUARDIAND, and finally command line arguments.NOTE: This PR changes existing behavior. Previously, if the file
node/config/guardiand.yamlexisted, it was loaded. However, this did not support specifying an arbitrary file location.If you were previously using
node/config/guardiand.yamlfor your configuration, please add--config node/config/guardiand.yamlto your command line.If a config file is loaded, a line like this will appear at the start of the log file: