8000 Plume testnet by aapclark · Pull Request #4414 · wormhole-foundation/wormhole · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Plume testnet #4414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 1, 2025
Merged

Plume testnet #4414

merged 3 commits into from
Jul 1, 2025

Conversation

aapclark
Copy link
Contributor
@aapclark aapclark commented Jun 30, 2025 •
edited
Loading 
-- Wormhole Core Addresses --------------------------------------------------
| Setup address                | 0x0B2719cdA2F10595369e6673ceA3Ee2EDFa13BA7 |
| Implementation address       | 0xaBf89de706B583424328B54dD05a8fC986750Da8 |
| Wormhole address             | 0x81705b969cDcc6FbFde91a0C6777bE0EF3A75855 |
-----------------------------------------------------------------------------

|- go run verify.go --env testnet --chainId 55
Verifying test plume...
   Verifying EVM chain ID for test plume ✓
   Verifying finality values for test plume ✓
   Verifying contract address for test plume ✓

evan-gray
evan-gray requested changes Jun 30, 2025
View reviewed changes
@aapclark
deploy WH core to Plume testnet
a99bddc 
```
-- Wormhole Core Addresses --------------------------------------------------
| Setup address                | 0x0B2719cdA2F10595369e6673ceA3Ee2EDFa13BA7 |
| Implementation address       | 0xaBf89de706B583424328B54dD05a8fC986750Da8 |
| Wormhole address             | 0x81705b969cDcc6FbFde91a0C6777bE0EF3A75855 |
-----------------------------------------------------------------------------
```

```
|- go run verify.go --env testnet --chainId 55
Verifying test plume...
   Verifying EVM chain ID for test plume ✓
   Verifying finality values for test plume ✓
   Verifying contract address for test plume ✓
```
@bruce-riley
Copy link
Contributor

Please update the PR description with the output from verify.go for the correct chain ID.

@aapclark
Copy link
Contributor Author
aapclark commented Jun 30, 2025 •
edited
Loading

Please update the PR description with the output from verify.go for the correct chain ID.

Just updated PR description to match the latest commit message.

@aapclark aapclark requested a review from evan-gray June 30, 2025 19:09
bruce-riley
bruce-riley requested changes Jun 30, 2025
View reviewed changes
Copy link
Contributor
@bruce-riley bruce-riley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update proto/publicrpc/v1/publicrpc.proto.

evan-gray
evan-gray requested changes Jun 30, 2025
View reviewed changes
Copy link
Contributor
@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the deployed contract matches the designated Wormhole Chain ID and EVM chain ID

However, this PR is missing changes from adminnodes.go and fails to add the chain to GetAllNetworkIDs which will prevent VAAs from being generated (IIRC). Also add the chain to publicrpc.proto otherwise the guardian will not respond to RPC requests for that chain ID. Please add any other missing chains while you are touching those files.

@aapclark
add plume to publicrpc.proto
4c4b3be 
add plume to adminnodes.go

add plume to GetAllNetworkIds
@aapclark aapclark requested a review from djb15 as a code owner June 30, 2025 19:24
@aapclark aapclark requested a review from evan-gray June 30, 2025 19:34
evan-gray
evan-gray requested changes Jun 30, 2025
View reviewed changes
Copy link
Contributor
@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick change then should be good

@aapclark aapclark requested a review from evan-gray June 30, 2025 20:18
@evan-gray evan-gray requested a review from bruce-riley July 1, 2025 03:29
@evan-gray evan-gray merged commit 08d6002 into wormhole-foundation:main Jul 1, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-gray evan-gray evan-gray approved these changes

@bruce-riley bruce-riley bruce-riley approved these changes

@panoel panoel Awaiting requested review from panoel panoel is a code owner

@SEJeff SEJeff Awaiting requested review from SEJeff SEJeff is a code owner

@gator-boi gator-boi Awaiting requested review from gator-boi gator-boi is a code owner

@kcsongor kcsongor Awaiting requested review from kcsongor kcsongor is a code owner

@djb15 djb15 Awaiting requested review from djb15 djb15 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aapclark @bruce-riley @evan-gray
0