8000 script: uses only first digest as identifier for governance prototxt by scnale · Pull Request #3950 · wormhole-foundation/wormhole · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

script: uses only first digest as identifier for governance prototxt #3950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2024
Merged

script: uses only first digest as identifier for governance prototxt #3950

merged 1 commit into from
Jun 4, 2024

Conversation

scnale
Copy link
Collaborator
@scnale scnale commented May 23, 2024 •
edited
Loading

This fixes the governance message document template when using multi mode.

When generating more than one governance message you could observe this being generated as the shell command to generate the prototxt:

cat << EOF > governance-206690B
259B804.prototxt
current_set_index:  4
[...]

Which breaks the format of the governance message.

@scnale scnale requested review from evan-gray and kcsongor as code owners May 23, 2024 15:15
@evan-gray evan-gray force-pushed the fix/governance-restrict-to-first-digest branch from 2aa3a6f to b9b35a7 Compare June 3, 2024 18:09
evan-gray
evan-gray approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor
@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@evan-gray evan-gray merged commit dc5e87f into main Jun 4, 2024
24 checks passed
@evan-gray evan-gray deleted the fix/governance-restrict-to-first-digest branch June 4, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcsongor kcsongor kcsongor approved these changes

@evan-gray evan-gray evan-gray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scnale @kcsongor @evan-gray
0