8000 XCOMMONS-1258: Allow parameters of rendering macro developed in Java to be ordered by surli · Pull Request #1330 · xwiki/xwiki-commons · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

XCOMMONS-1258: Allow parameters of rendering macro developed in Java to be ordered #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

XCOMMONS-1258: Allow parameters of rendering macro developed in Java to be ordered #1330

wants to merge 3 commits into from

Conversation

surli
Copy link
Member
@surli surli commented May 13, 2025

Jira URL

https://jira.xwiki.org/browse/XCOMMONS-1258

Changes

Description

  • Provide new annotation for property ordering
  • Provide needed getters/setters and parsing of the annotation

Clarifications

  • This work is not yet used: it will need some work in xwiki-platform to be used.

Screenshots & Video

Executed Tests

mvn clean install -Pquality in impacted module

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • None

@surli
XCOMMONS-1258: Allow parameters of rendering macro developed in Java …
1668734 
…to be ordered

  * Provide new annotation for property ordering
@tmortagne
Copy link
Member

I would expect BeanDescriptor#getProperties() result to be sorted according to this new metadata.

@surli
XCOMMONS-1258: Allow parameters of rendering macro developed in Java …
cb96e50 
…to be ordered

  * Handle order ing BeanDescriptor#getProperties
@surli
Copy link
Member Author
surli commented May 13, 2025

I would expect BeanDescriptor#getProperties() result to be sorted according to this new metadata.

Indeed, thanks for the hint I just added that.

@surli surli mentioned this pull request May 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account 5D17 ? Sign in to comment
Reviewers

@tmortagne tmortagne tmortagne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@surli @tmortagne
0