8000 Handle difference in base64 on MacOS by Moulick · Pull Request #124 · xxh/xxh · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Handle difference in base64 on MacOS #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2021
Merged

Handle difference in base64 on MacOS #124

merged 1 commit into from
Dec 19, 2021

Conversation

Moulick
Copy link
Contributor
@Moulick Moulick commented Dec 17, 2021 •
edited
Loading
  • bas64 in macos uses -b (break) instead of --wrap, and it's 0 by default
  • ran the file through shellcheck, implemented some of the improvements to handle unexpected glob expansion and a few others
    Fixes base64 --wrap=0 does not work on Mac #123

@Moulick
Handle difference in base64 on MacOS
d6b5750 
bas64 in macos uses -b (break) instead of --wrap, and it's 0 by default
+ ran the file through shellcheck, implemented some of the improvements to handle unexpected glob expansion and a few others
Fixes #123
@Moulick Moulick changed the title Handle difference in base64 on MacOS, Fixes https://github.com/xxh/xxh/issues/123 Handle difference in base64 on MacOS Dec 17, 2021
@Moulick Moulick mentioned this pull request Dec 17, 2021
Closed
@anki-code anki-code merged commit 67e9342 into xxh:master Dec 19, 2021
@anki-code
Copy link
Member

Hi @Moulick! Thank you for this great fix!

@anki-code anki-code added this to the 0.8.8 milestone Dec 19, 2021
@Moulick Moulick deleted the Moulick-patch-1 branch December 19, 2021 19:56
@Moulick
Copy link
Contributor Author
Moulick commented Dec 19, 2021 •
edited
Loading

Happy to help :)
@anki-code when would you release a new version with this fix ?

@anki-code
Copy link
Member

@Moulick 0.8.8 is here )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.8
Development

Successfully merging this pull request may close these issues.

base64 --wrap=0 does not work on Mac
2 participants
@Moulick @anki-code
0