Node Status Indicator Revamp #916
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
There was a problem hiding this comment.
Pull Request Overview
This PR extends the NodeStatusIndicator to support an initial state, adds two loading variants (border and overlay), and updates documentation, component code, and examples accordingly.
- Introduced
NodeStatusLoadingVariantprop to switch between border and overlay loading indicators - Refactored and renamed loading indicator components; updated default loading variant
- Updated documentation and registry examples to showcase each status and variant
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sites/reactflow.dev/src/content/components/nodes/node-status-indicator.mdx | Added initial state and documented new loadingVariant options |
| apps/ui-components/registry/components/node-status-indicator/index.tsx | Added loadingVariant prop, split loading indicators, updated switch logic |
| apps/ui-components/registry/components/node-status-indicator/component-example.tsx | Replaced default export with multiple named examples for each status/variant |
| apps/ui-components/registry/components/node-status-indicator/app-example.tsx | Updated node definitions and nodeTypes mapping for new example components |
Comments suppressed due to low confidence (3)
sites/reactflow.dev/src/content/components/nodes/node-status-indicator.mdx:9
- [nitpick] Consider adding a brief usage example or note on what the
initialstate looks like in practice, so readers know when and how to apply it.
A node wrapper that has multiple states for indicating the status of a node. Status can be one of the following: `success`, `loading`, `error` and `initial`.
apps/ui-components/registry/components/node-status-indicator/index.tsx:15
- [nitpick] The name
SpinnerLoadingIndicatordescribes the inner spinner but doesn’t convey that this is the overlay variant. Consider renaming toOverlayLoadingIndicatorfor consistency withBorderLoadingIndicator.
export const SpinnerLoadingIndicator = ({
apps/ui-components/registry/components/node-status-indicator/index.tsx:29
- The CSS
calcexpressions lack spaces around the operator, which may lead to invalid parsing. Useleft-[calc(50% - 1.25rem)]andtop-[calc(50% - 1.25rem)]for correct syntax.
<span className="absolute left-[calc(50%-1.25rem)] top-[calc(50%-1.25rem)] inline-block h-10 w-10 animate-ping rounded-full bg-blue-700/20" />
apps/ui-components/registry/components/node-status-indicator/index.tsx
Outdated
Show resolved
Hide resolved
|
Not yet!
It would need some re-design of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.