[android] always log expected location of xbmc_env.properties #26803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds an informational log statement to show where xbmc_env.properties should be placed on Android devices.
- Always logs the constructed path for
xbmc_env.properties - No functional behavior changes beyond logging
Comments suppressed due to low confidence (1)
tools/android/packaging/xbmc/src/XBMCProperties.java.in:34
- Avoid manual path concatenation. Use the File constructor for clarity:
File fProp = new File(Storage.getPrimaryStorageVolumePath(mContext), "xbmc_env.properties");
String propfn = fProp.getAbsolutePath();String propfn = Storage.getPrimaryStorageVolumePath(mContext) + "/xbmc_env.properties";
| @@ -32,6 +32,8 @@ public class XBMCProperties | |||
| public static void initializeProperties() | |||
| { | |||
| String propfn = Storage.getPrimaryStorageVolumePath(mContext) + "/xbmc_env.properties"; | |||
| Log.i(TAG, "XBMCProperties: Expected at " + propfn); | |||
There was a problem hiding this comment.
The log tag already identifies the class, so the message prefix "XBMCProperties: " is redundant. Consider using Log.i(TAG, "Expected at " + propfn); instead.
Copilot uses AI. Check for mistakes.
garbear
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prints expected location of
xbmc_env.propertiesfile to syslog (accessible viaadb logcat)Motivation and context
From the wiki it's not that clear where to put the file
How has this been tested?
checked syslog on Android 15 phone and Android 11 TV box
What is the effect on users?
User can see the expected location of the file clearly
Types of change
Checklist: