2580 add optional dependency of watchgod #2583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks and all good! The only thing is that you currently need to also do it here: https://github.com/xlwings/xlwings/blob/main/setup.py#L44-L59 as the Windows packaging still relies on setup.py because of the dll handling. |
|
Thank you for a quick response Felix! I have added the optional dependency to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2580
Simply adds a new optional dependency to pyproject.toml of the watchgod library enablings the usage of
xlwings vba editvia uv:uvx --from 'xlwings[vba_edit]' xlwings vba edit"
To test (before it gets merged) use the following:
uvx --from "git+https://github.com/MEMAndersen/xlwings.git@2580-Add-optional-dependency-of-watchgod[vba_edit]" xlwings vba editSee also https://docs.astral.sh/uv/guides/tools/#requesting-extras
When #1963 is adressed the optional dependency should be updated
It is my first time contributing to anything so please guide or correct me if i am doing something wrong