fix!: preserve DOCTYPE internal subset #498
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Thx, I will have a closer look over the weekend. |
This reverts commit 1966113.
This comment was marked as outdated.
This comment was marked as outdated.
and document it, update snapshots
|
The regular expressions no longer have a I managed to split the methods again, so they have a managable/testable amount of complexity. The rino example is currently failing, so I have to fix that. The only other thing missing is to add some unit tests for those new methods and for the new error messages, before the PR can be landed. |
|
Rhino doesn't seem to support named groups, which we are now using to get understandable results for ExternalIDs... But I will risk having to change the regular expression and code to make it compatible in a later PR, once it's merged and published, just to see if anybody complains. |
|
@shunkica From my perspective I would land this. Let me know whether you agree or disagree :) Great endurance on this contribution, and I'm looking forward to the next one :) |
|
@karfau I agree. Let's proceed with merging, and we'll tackle any issues that arise in subsequent updates. |
|
landed, I will be able to make a new beta release on the |
|
released as 0.9.0-beta.9 under the |
which is a regression compared to 0.8.x, most likely introduced as part of #498 - add check to `parseDoctypeCommentOrCData` - drop redundant and broken `Element.appendChild` implementation - `hasInsertableNodeType` now checks for `CharacterData` nodes instead of only text nodes - align ParseError and DOMException in how they are extending Error - wrap `DOMException`s in `ParseError` in sax parser - move custom errors to own module - and allow current and modern constructor arguments for DOMException
Add support for parsing the internal subset of a DOCTYPE and saving it as a string in
DocumentType.internalSubset.BREAKING CHANGE: Many documents that were previously accepted by xmldom, esecially non well-formed ones are no longer accepted. Some issues that were formerly reported as
errors are now afatalError.fixes #117, #497
Spec: XML DOM L2 Core