8000 chore: minimum tested node version is 14 by karfau · Pull Request #710 · xmldom/xmldom · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: minimum tested node version is 14 #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 30, 2024
Merged

chore: minimum tested node version is 14 #710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ceaaafa
chore: minimum tested node version is 14
karfau Aug 30, 2024
93799f5
ci: run checks for node v22
karfau Aug 30, 2024
a14dc88
Merge branch 'master' into min-node-version-14
karfau Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 3 additions & 39 deletions .github/workflows/examples.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,11 @@ jobs:
strategy:
matrix:
node-version:
- 10
- 12
- 14
- 16
- 18
- 20
- 22

steps:
- name: Harden Runner
Expand All @@ -50,48 +49,13 @@ jobs:
- 3
- 4
- "5.0" # requires node version 12.20
# starting with typescript 5.1 the minimum required node version is 14.17
# so current versions have a separate job without node v12
node-version:
- 12
- 14
- 16
- 18
- 20

steps:
- name: Harden Runner
uses: step-security/harden-runner@5c7944e73c4c2a096b17a9cb74d65b6c2bbafbde # v2.9.1
with:
egress-policy: audit

- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
with:
node-version: ${{ matrix.node-version }}
- run: ./pretest.sh ${{ matrix.ts-version }}
working-directory: examples/typescript-node-es6
- run: node --experimental-modules dist/index.js
if: ${{ matrix.node-version == 12 }}
working-directory: examples/typescript-node-es6
- run: node dist/index.js
if: ${{ matrix.node-version > 12 }}
working-directory: examples/typescript-node-es6
typescript51-node-es6:
# starting with typescript 5.1 the minimum required node version is 14.17

runs-on: ubuntu-latest

strategy:
matrix:
ts-version:
- 5
- 5 # typescript >=5.1 requires node version >=14.17
node-version:
- 14
- 16
- 18
- 20
- 22

steps:
- name: Harden Runner
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/test-node.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
- 16
- 18
- 20
- 22

steps:
- name: Harden Runner
Expand All @@ -38,12 +39,12 @@ jobs:
node-version: ${{ matrix.node-version }}
- run: npm ci --no-audit
- run: npm run test
if: matrix.node-version != 16
if: matrix.node-version != 18
- run: npm run test -- --coverage
if: matrix.node-version == 16
if: matrix.node-version == 18
- run: npm run fuzz
if: matrix.node-version == 16
- if: matrix.node-version == 16
if: matrix.node-version == 18
- if: matrix.node-version == 18
uses: codecov/codecov-action@e28ff129e5465c2c0dcc6f003fc735cb6ae0c673 # v4.5.0
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"release": "np --no-yarn --test-script testrelease"
},
"engines": {
"node": ">=10.0.0"
"node": ">=14.0.0"
},
"devDependencies": {
"@homer0/prettier-plugin-jsdoc": "9.0.2",
Expand Down
0