fix: sync types with exports #717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and export enum DOMExceptionName
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #717 +/- ##
==========================================
+ Coverage 94.26% 94.35% +0.09%
==========================================
Files 8 8
Lines 2094 2092 -2
Branches 537 537
==========================================
Hits 1974 1974
+ Misses 120 118 -2 ☔ View full report in Codecov by Sentry. |
and drop Element methods from Node prototype
for supporting `console.*`
to avoid CodeQL warning. This revealed some issues in the implementation and types, which were fixed along the way - drop `ParseError.cause` since it never worked
instead of just the enum values to be passed
- drop copied references to NoteListOf and generics - include index.d.ts into `format` script
1 task
and missing `Document.getElementsByTagName/-NS`
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOMExceptionNameMIME_TYPEandNAMESPACEtovarand literal type to reflect actual codehasDefaultHTMLNamespace/// <reference lib="dom" />(added@types/nodeto examples forconsoleandprocess.exit)DOMImplementation,Document,Node,DocumentTypeNodeList,LiveNodeListElement,Attr,NamedNodeMapCharacterData,CDATASection,Comment,TextDocumentFragmentEntityReference,Entity,Notation,ProcessingInstructionfixes #695