8000 fix: replace \u2029 as part of normalizeLineEndings by kboshold · Pull Request #839 · xmldom/xmldom · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: replace \u2029 as part of normalizeLineEndings #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 25, 2025
Merged

fix: replace \u2029 as part of normalizeLineEndings #839

merged 6 commits into from
Feb 25, 2025

Conversation

kboshold
Copy link
Contributor
@kboshold kboshold commented Feb 18, 2025 •
edited by karfau
Loading

Fixes #838, when the default normalizeLineEndings implementation is being used

@codecov Codecov
Copy link
codecov bot commented Feb 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.12%. Comparing base (00a686f) to head (2aa6dce).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #839   +/-   ##
=======================================
  Coverage   95.12%   95.12%           
=======================================
  Files           8        8           
  Lines        2195     2196    +1     
  Branches      577      577           
=======================================
+ Hits         2088     2089    +1     
  Misses        107      107

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ponynjaa Ponynjaa requested a review from karfau February 18, 2025 11:29
@karfau karfau changed the title fix: fixed linePattern regexp to allow \u2028 and \u2029 (#838) fix: replace \u2029 as part of normalizeLineEndings Feb 19, 2025
karfau
karfau approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member
@karfau karfau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thx a lot

@karfau karfau merged commit cc00fa9 into xmldom:master Feb 25, 2025
38 checks passed
@karfau karfau added this to the 0.9.8 milestone Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karfau karfau karfau approved these changes

@Ponynjaa Ponynjaa Ponynjaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.8
Development

Successfully merging this pull request may close these issues.

Increased processing times when using \u2028 and \u2029
3 participants
@kboshold @karfau @Ponynjaa
0