GRAPHICS: Add new flexible takeImage method #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, what's the reason for using futures here? Does taking a screenshot really take so much time that we need to do that asynchronously? |
|
The Problem with the current architecture is that the renderer and the game logic are running in different threads. The current approach is good, if you want to take a screenshot and just throw it into a file and don't care from the point of view of the game. But this method was intended for creating screenshots which can be used for the save games, where you actually need the image inside the game logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Method aims to be a more flexible approach for creating screenshots especially targeted towards the save game screenshot creation. Maybe it might even replace someday the takeScreenshot Method? It contains std::future and therefore needs C++11.