Prevent focus loss after save #5742
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the improved PR and the explanations. I experienced jumping in the cursor position when saving while editing text. |
|
Thanks for reviewing my PR! The video demonstration is also made using x11, on Debian 12, Xfce spin, which is quite interesting. I will try to reproduce the behavior later. I could be wrong but my initial thoughts are that the problem may lie in floating point operation precision e.g. dividing and then multiplying by a zooming factor may not preserve initial coordinates. |
|
I tried to replicate the wrong behavior, but had no luck: 2024-08-30.19-16-26.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5132
Before
before.mp4
After
after.mp4
This pull request updates #5702 by now accounting for zooming.
Explanation
In a previous pull request,
pos.xandpos.yalready accounted for zooming, whileonButtonPressEventandonButtonReleaseEventexpected positions that did not account for zooming.onButtonPressEventandonButtonReleaseEventwere applying zooming by dividing coordinates by a zooming factor.To place the cursor in the correct position, I had to multiply
pos.xandpos.yby the zooming factor.Possible Improvements
This is not the only solution I considered. There were improvements I wanted to make, but due to my limited understanding of the contribution requirements, I was unsure whether they would be beneficial.
While writing this pull request, I tried to be as concise as possible, changing a minimal number of files and making the least number of additions. Yet, it is not the most elegant or correct solution.
I believe that the correct solution would be to add a new method to the
TextEditorclass namedsync, which would synchronize theTextEditorcontents with a text element, without closing theTextEditor(freeing the pointer). Then, we would refactor thecloseSelectionEndTextmethod intocloseSelectionSyncText, which would call thesyncmethod instead of freeing the pointer. However, this seemed as an overkill for such small enhancement, so I implemented a simple, hacky solution.My current solution feels hacky because the
onButtonPressEventandonButtonReleaseEventmethods weren't intended to be used this way. The fact that coordinates were divided by the zooming factor, only to be multiplied by it again, seems a bit inelegant. Nonetheless, the solution works, and it is the only one I could implement without refactoring many classes and methods.