8000 Dropped Subscription Id Causing `unobserve` to trigger by Waidhoferj · Pull Request #26 · y-crdt/ypy · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Apr 22, 2025. It is now read-only.

Dropped Subscription Id Causing unobserve to trigger #26

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

Waidhoferj
Copy link
Collaborator

I added a test based on a variation of what was described in #23 . Could not reproduce the invalid behavior locally.

@Waidhoferj Waidhoferj requested a review from davidbrochart April 4, 2022 22:08
@Waidhoferj Waidhoferj self-assigned this Apr 4, 2022
@Waidhoferj Waidhoferj added the bug Something isn't working label Apr 4, 2022
@davidbrochart
Copy link
Collaborator

Could not reproduce the invalid behavior locally.

That was happening with v0.3.0, but it was fixed in main already.

@dmonad dmonad closed this Apr 5, 2022
@dmonad dmonad reopened this Apr 5, 2022
@Waidhoferj Waidhoferj marked this pull request as ready for review April 6, 2022 18:29
@Waidhoferj Waidhoferj merged commit dfa4828 into main Apr 6, 2022
@Waidhoferj Waidhoferj deleted the drop-sub-id branch April 6, 2022 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0