Netscaler multiple partition support #1596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1596 +/- ##
=======================================
Coverage 62.62% 62.62%
=======================================
Files 30 30
Lines 1493 1493
=======================================
Hits 935 935
Misses 558 558Continue to review full report at Codecov.
|
|
Can you fix the conflict |
952ead3 to
c344283
Compare
|
I've rebased and updated the changelog in line with the new format. I've no longer got access to a netscaler to test this change on, but the rebase should only have impacted the changelog. |
|
Can you fix the conflict again (sorry. We have to change the CHANGELOG to a more flexible variant...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Request Checklist
rubocop --auto-correct)rake test)Description
Citrix Netscalers have functionality for logical partitioning, where each partition has its own config. This pull request enhances oxidized to check for presence of these additional config partitions and retrieves the configuration from them if present.
It is modeled on the asa model which has similar logical config separation in contexts.