8000 Add Digest HTTP Authentication with Basic Auth Fallback by derhelge · Pull Request #3074 · ytti/oxidized · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Digest HTTP Authentication with Basic Auth Fallback #3074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2024
Merged

Add Digest HTTP Authentication with Basic Auth Fallback #3074

merged 1 commit into from
Feb 19, 2024
+31 −7

Conversation

derhelge
Copy link
Contributor

Description

This patch introduces the ability to perform Digest HTTP authentication when making requests. If Digest authentication is not required or fails, the method falls back to Basic authentication. This enhancement provides more flexibility in handling different authentication schemes and improves compatibility with various systems.

Fixes #2685.

@ytti ytti merged commit e59b50f into ytti:master Feb 19, 2024
@derhelge derhelge deleted the http-digest-auth branch February 19, 2024 09:30
@derhelge
Copy link
Contributor Author

Hi @ytti thanks for accepting the pull request. Unfortunately i introduced a bug:
Line 60 in http.rb should be:
if res.code == '401' && res['www-authenticate']&.include?('Digest')
Elsewhat basic auth stops working because res['www-authenticate'] is nil. Sorry

@ytti
Copy link
Owner
ytti commented Feb 19, 2024

Submit new PR for the safe navigation, no problem.

@robertcheramy
Copy link
Collaborator

This PR introduced RuboCop Warnings (Layout/TrailingWhitespace).
The GitHub checks did not run (I don't know why), so it could not easily been seen.
These warnings will be fixed with PR #3079.

@derhelge
Copy link
Contributor Author

Thanks @robertcheramy
I apologize that you had extra work due to my inability. I am not a Ruby developer and am still learning how to use oxidized dev-wise.

@robertcheramy
Copy link
Collaborator

@derhelge - no problem. Thank you for contributing to oxidized!

@derhelge derhelge mentioned this pull request Feb 21, 2024
Closed
@robertcheramy robertcheramy mentioned this pull request Apr 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SwOS model not working due to HTTP Digest
3 participants
@derhelge @ytti @robertcheramy
< 3047 div hidden> Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
0