Add support for AsciiDoc #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzhang-gh
reviewed
Sep 17, 2023
| @@ -3,7 +3,7 @@ | |||
| "displayName": "Dictionary Completion", | |||
| "description": "Word Completion", | |||
| "icon": "images/dictionary.png", | |||
| "version": "1.2.2", | |||
| "version": "1.2.3", | |||
There was a problem hiding this comment.
We usually do not update the version number in a feature commit. Just leave it to me and I will publish a new version after this PR is merged in.
There was a problem hiding this comment.
Fair enough, would leave it out, thanks.
| @@ -214,6 +215,8 @@ class DictionaryCompletionItemProvider implements vscode.CompletionItemProvider | |||
| } | |||
|
|
|||
| switch (this.fileType) { | |||
| case "asciidoc": | |||
| return this.completeByFirstLetter(firstLetter, addSpace); | |||
There was a problem hiding this comment.
Looks good. But I guess there are some cases where we do not want a completion (e.g. urls). You can use regex101 (select ECMAScript in the left panel) to help you write those rules.
There was a problem hiding this comment.
Thanks, would need to test it more in that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for AsciiDoc since the extension comes handy when writing. Thanks!