8000 check component before detect viewport by kaesonho · Pull Request #36 · yahoo/react-i13n · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

check component before detect viewport #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2015
Merged

check component before detect viewport #36

merged 1 commit into from
Jul 30, 2015

Conversation

kaesonho
Copy link
Contributor

with #31 , we detect viewport recursively from the root , while we sometimes get

Uncaught TypeError: Cannot read property '_recursiveDetectViewport' of undefined

we wait until latest componentDidMount happen then start detecting viewport from the root, and suppose we can always getReactComponent for each i13n node, it can be caused when we start detection but some component is still mounting,

so do clearTimeout(pageInitViewportDetectionTimeout); in componentWillMount should solve the problem

also add error handling

@redonkulus @kfay

@kaesonho kaesonho changed the title Checkcomponent check component before detect viewport Jul 30, 2015
@redonkulus
Copy link
Contributor

👍

@yahoocla
Copy link

CLA is valid!

kaesonho added a commit that referenced this pull request Jul 30, 2015
@kaesonho
Merge pull request #36 from yahoo/checkcomponent
5b40e59 
check component before detect viewport
@kaesonho kaesonho merged commit 5b40e59 into master Jul 30, 2015
@kaesonho kaesonho deleted the checkcomponent branch July 30, 2015 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaesonho @redonkulus @yahoocla
0