8000 feat: add YIP-62 by philburrrt · Pull Request #403 · yearn/yearn-docs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on May 1, 2023. It is now read-only.

feat: add YIP-62 #403

Merged
merged 2 commits into from
Jun 29, 2021
Merged

feat: add YIP-62 #403

merged 2 commits into from
Jun 29, 2021

Conversation

philburrrt
Copy link
Contributor

also fixed minor formatting errors

- fixed images separating list in 'working on docs'
- fixed caption breaking images in 'vault tokens' and 'how to understand yveCRV'
- removed capital letters from hegic file so it would display
Copy link
Contributor
@lehnberg lehnberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

Friendly feedback point to try to avoid attaching unrelated commits (fix: formatting errors) alongside a PR that does something completely orthogonal (add YIP-62).

Better to submit a separate "fix formatting errors" PR, easier to review. 👍

@lehnberg lehnberg merged commit 84f3236 into yearn:master Jun 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
3087
0