8000 feat: adds `inline` option to element-newline; fixes #210 by RobertAKARobin · Pull Request #214 · yeonjuan/html-eslint · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: adds inline option to element-newline; fixes #210 #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 11, 2024
Merged

feat: adds inline option to element-newline; fixes #210 #214

merged 11 commits into from
Sep 11, 2024

Conversation

RobertAKARobin
Copy link
Contributor
  • Adds additional error messages to element-newline, so that it specifies whether a space is needed between a tag and its content or between two sibling elements
  • Adds an inline option to element-newline, indicating that the specified elements can be on the same line when they are siblings

@RobertAKARobin RobertAKARobin mentioned this pull request Sep 4, 2024
Closed
yeonjuan
yeonjuan approved these changes Sep 9, 2024
View reviewed changes
Copy link
Owner
@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks for working it. I like the idea of using something like $inline.

@yeonjuan yeonjuan merged commit 7a9f5e3 into yeonjuan:main Sep 11, 2024
3 checks passed
@RobertAKARobin RobertAKARobin deleted the inlines branch September 11, 2024 10:28
@RobertAKARobin
Copy link
Contributor Author

Thanks @yeonjuan ! When do you think you'll cut a new release on npm?

@yeonjuan
Copy link
Owner

@RobertAKARobin I'm sorry for the late reply. I'm going to publish it this weekend :)

This was referenced Oct 28, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeonjuan yeonjuan yeonjuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobertAKARobin @yeonjuan
0