fix: handle template expression in no-invalid-role #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with the "no-invalid-role" rule by handling template expressions correctly in both the rule implementation and its tests.
- Updated test cases to include template expressions for role attributes.
- Modified the rule to bypass validation when a template expression is detected.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/eslint-plugin/tests/rules/no-invalid-role.test.js | Added a test case for template expressions in role attributes. |
| packages/eslint-plugin/lib/rules/no-invalid-role.js | Introduced an early return to bypass template expressions during role validation. |
Comments suppressed due to low confidence (1)
packages/eslint-plugin/lib/rules/no-invalid-role.js:257
- [nitpick] Consider adding an inline comment to explain why template expressions are skipped in the role validation, which would improve the code's maintainability and clarity for future developers.
if (role.value && role.value.parts.some((part) => part.type === NodeTypes.Template)) {
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #335 +/- ##
=======================================
Coverage 98.53% 98.54%
=======================================
Files 76 76
Lines 2324 2329 +5
Branches 636 639 +3
=======================================
+ Hits 2290 2295 +5
Misses 34 34
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
no-invalid-roleshould not report error for dynamic role attribute in template expression #334Description