fix: crash with template expression in no-trailing-spaces #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a crash in the no-trailing-spaces rule when using template expressions by correcting location calculations and improving error reporting.
- Updated tests to include explicit line, column, and endColumn properties for error objects.
- Modified the check function to accept an offset object (with range, line, and column properties) for precise location adjustments.
- Adjusted the fixer logic to remove trailing spaces based on computed indices.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/eslint-plugin/tests/rules/no-trailing-spaces.test.js | Updated test cases to validate accurate error locations in both plain and tagged templates. |
| packages/eslint-plugin/lib/rules/no-trailing-spaces.js | Refactored the check function’s offset handling and updated the fixer to remove trailing spaces correctly. |
Comments suppressed due to low confidence (1)
packages/eslint-plugin/lib/rules/no-trailing-spaces.js:86
- The variable 'end' is used in the fixer function but is not defined. Define 'end' (e.g., by setting const end = sourceCode.getIndexFromLoc(loc.end)) before using it in fixer.removeRange to ensure the correct removal range.
return fixer.removeRange([start, end]);
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #337 +/- ##
==========================================
- Coverage 98.54% 98.54% -0.01%
==========================================
Files 76 76
Lines 2332 2331 -1
Branches 640 641 +1
==========================================
- Hits 2298 2297 -1
Misses 34 34
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
https://html-eslint.org/playground#eyJjb2RlIjoiaHRtbGA8ZGl2PiAgXG4gICAgICAgIDxzcGFuPlxuICAgIDwvc3Bhbj5cbiAgICA8L2Rpdj5cbmBcbiIsImNvbmZpZyI6eyJydWxlcyI6eyJAaHRtbC1lc2xpbnQvbm8tdHJhaWxpbmctc3BhY2VzIjoiZXJyb3IifX0sImxhbmd1YWdlIjoiamF2YXNjcmlwdCJ9
Fixed bug reporting incorrect location when used with template expression.
Description