8000 feat: update baseline data by yeonjuan · Pull Request #330 · yeonjuan/html-eslint · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: update baseline data #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025
Merged

feat: update baseline data #330

merged 1 commit into from
May 1, 2025

Conversation

yeonjuan
Copy link
Owner
@yeonjuan yeonjuan commented Apr 29, 2025

Checklist

  • update bcd data

Description

@yeonjuan yeonjuan requested a review from Copilot April 29, 2025 16:41
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the baseline data for HTML element attributes in the ESLint plugin. It introduces new baseline entries for several elements (e.g. caption, col, link, script, table, tbody, th, thead, tr), with most new entries initialized to a default value of "0:".

Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (2)

packages/eslint-plugin/lib/rules/utils/baseline.js:93

  • Confirm that 'caption.align' is expected to have a default baseline value of '0:' as this deviates from the standard baseline score applied to similar attributes.
["caption.align", "0:"],

packages/eslint-plugin/lib/rules/utils/baseline.js:469

  • Verify that all newly added table properties (e.g. table.align, table.bgcolor, table.border, etc.) are intentionally set to '0:' and that this default value aligns with the intended baseline specification.
["table.align", "0:"],

@yeonjuan yeonjuan marked this pull request as ready for review April 29, 2025 17:30
@yeonjuan yeonjuan merged commit b34875b into main May 1, 2025
6 checks passed
@yeonjuan yeonjuan deleted the update-basline branch May 1, 2025 06:06
Copy link
codecov bot commented May 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (8f32c6d) to head (e77884a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #330   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files          73       73           
  Lines        2200     2200           
  Branches      604      604           
=======================================
  Hits         2172     2172           
  Misses         28       28           
Flag Coverage Δ
unittest 98.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/eslint-plugin/lib/rules/utils/baseline.js 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0