8000 fix: correct rule `require-open-graph-protocol` description by ntnyq · Pull Request #342 · yeonjuan/html-eslint · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: correct rule require-open-graph-protocol description #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ntnyq
Copy link
Contributor
@ntnyq ntnyq commented May 14, 2025

Checklist

None.

Description

This PR fixes the meta.docs.description property content of rule require-open-graph-protocol.

@yeonjuan yeonjuan requested a review from Copilot May 14, 2025 14:16
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects the description for the rule "require-open-graph-protocol" by updating the meta.docs.description content to better reflect the intended functionality.

  • Updated the description text from referencing a viewport meta tag to specifying open graph protocol meta tags.

@@ -42,7 +42,8 @@ module.exports = {
type: "code",

docs: {
description: 'Enforce to use `<meta name="viewport">` in `<head>`',
description:
Copy link
Preview
Copilot AI May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider providing additional details by listing the specific open graph meta tags that the rule enforces to aid user understanding.

Copilot uses AI. Check for mistakes.

@yeonjuan
Copy link
Owner

HI @ntnyq Thank you for the fix! Could you also run yarn build at the root and commit the updated .md files as well?

@ntnyq
Copy link
Contributor Author
ntnyq commented May 14, 2025

HI @ntnyq Thank you for the fix! Could you also run yarn build at the root and commit the updated .md files as well?

Updated.

Copy link
Owner
@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 👍

@yeonjuan yeonjuan merged commit abb2404 into yeonjuan:main May 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0