fix: ignore checking tag names in svg in lowercase #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #350 by refining the ESLint rule that validates tag names to better handle SVG elements.
- Introduces new test cases for nested SVG elements (e.g. clipPath) and for auto-correcting uppercase SVG tags.
- Updates the rule logic in lowercase.js by incorporating svgStack and using isScript/isStyle helper functions to determine tag names.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/eslint-plugin/tests/rules/lowercase.test.js | Added test cases to verify correct handling of SVG-related tags |
| packages/eslint-plugin/lib/rules/lowercase.js | Modified condition in the check function to ensure only incorrect tag cases are reported |
Comments suppressed due to low confidence (2)
packages/eslint-plugin/lib/rules/lowercase.js:79
- [nitpick] The updated condition that checks svgStack and the tag name could benefit from an inline comment explaining its intent, to assist future maintainers in understanding why SVG tags are treated differently.
if (name !== raw && (svgStack.length === 0 || name.toLowerCase() === "svg")) {
packages/eslint-plugin/tests/rules/lowercase.test.js:46
- [nitpick] Consider adding an inline comment in this test case to clarify that the non-lowercase tag names nested within SVG elements are intentionally not flagged, improving test readability.
{ code: `<svg viewBox="0 0 100 100">
<clipPath id="myClip">
<circle cx="40" cy="35" r="35" />
</clipPath>
</svg>
`, }
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
=======================================
Coverage 98.29% 98.29%
=======================================
Files 79 79
Lines 2515 2517 +2
Branches 685 687 +2
=======================================
+ Hits 2472 2474 +2
Misses 43 43
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
lowercaserule incorrectly flags case-sensitive SVG elements likeclipPath#350Description