fix: wrong rule category #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the rule categories for two ESLint rules to correctly reflect their intended purposes.
- Updates the category for "no-extra-spacing-text" from BEST_PRACTICE to STYLE.
- Updates the category for "max-element-depth" from STYLE to BEST_PRACTICE.
- Revises the documentation in docs/rules.md to match the corrected rule categories.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/eslint-plugin/lib/rules/no-extra-spacing-text.js | Changed rule category from BEST_PRACTICE to STYLE. |
| packages/eslint-plugin/lib/rules/max-element-depth.js | Changed rule category from STYLE to BEST_PRACTICE. |
| docs/rules.md | Updated the documentation table to reflect the new categorization. |
Comments suppressed due to low confidence (3)
packages/eslint-plugin/lib/rules/no-extra-spacing-text.js:33
- Confirm that updating the rule category to STYLE accurately reflects its intended usage and behavior.
category: RULE_CATEGORY.STYLE,
packages/eslint-plugin/lib/rules/max-element-depth.js:28
- Ensure that changing the category to BEST_PRACTICE is consistent with the rule's behavior and affects rule grouping as intended.
category: RULE_CATEGORY.BEST_PRACTICE,
docs/rules.md:73
- Verify that the documentation table update aligns with the new rule categories to maintain consistent communication to users.
| [no-extra-spacing-text](rules/no-extra-spacing-text) | Disallow unnecessary consecutive spaces | 🔧 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
no-extra-spacing-textandmax-element-depthrules #354Description