8000 [PAN-3] Expound options: `:print-object?` by kelvinqian00 · Pull Request #34 · yetanalytics/project-pan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[PAN-3] Expound options: :print-object? #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 19, 2022
Merged

[PAN-3] Expound options: :print-object? #34

merged 4 commits into from
Apr 19, 2022

Conversation

kelvinqian00
Copy link
Contributor
@kelvinqian00 kelvinqian00 commented Apr 19, 2022 •
edited
Loading

Add a :error-msg-opt kwarg to the API functions, which accept an opt map for functions to toggle error message display values. Currently :error-msg-opt only accepts :print-object?, which toggles whether objects or only IDs are printed (former is true and is the default, latter is false), but can be expanded in future updates.

@kelvinqian00 kelvinqian00 changed the base branch from main to version_5 April 19, 2022 20:54
@kelvinqian00 kelvinqian00 mentioned this pull request Apr 19, 2022
Merged
@kelvinqian00 kelvinqian00 merged commit 1ec78ae into version_5 Apr 19, 2022
@kelvinqian00 kelvinqian00 deleted the expound_noprint_obj branch April 19, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cliffcaseyyet cliffcaseyyet cliffcaseyyet approved these changes

Assignees
No one assigned
Labels 47CA
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kelvinqian00 @cliffcaseyyet
0