Move capturing up to the state object #880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeldrapper
commented
Mar 17, 2025
Comment on lines
+356
to
359
| def vanish(...) | ||
| capture(...) | ||
| nil | ||
| end |
There was a problem hiding this comment.
I think this is a reasonable simplification here. It allocates a string but I think it’s fine.
There was a problem hiding this comment.
Yeah I think so. The typical use case for vanish is that you'd be calling it with a block that shouldn't contain any direct element calls. So the performance optimization of Phlex::Vanish probably wasn't even being used much.
joeldrapper
commented
Mar 17, 2025
Comment on lines
-19
to
-26
| def buffer | ||
| case @buffer | ||
| when Proc | ||
| @buffer.call | ||
| else | ||
| @buffer | ||
| end | ||
| end |
There was a problem hiding this comment.
We never needed this.
willcosgrove
approved these changes
Mar 17, 2025
|
<3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fix yippee-fun/phlex-rails#276, we need to simplify the capturing interface so it can be swapped out. This PR removes the ability to capture into an arbitrary buffer. Instead, it depends on reading the new buffer from the state within a capture block.
See yippee-fun/phlex-rails#279