8000 add test case for search resolution "word" by StefanVukovic99 · Pull Request #939 · yomidevs/yomitan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add test case for search resolution "word" #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2024

Conversation

StefanVukovic99
Copy link
Collaborator

This is on top of #938

@StefanVukovic99 StefanVukovic99 requested a review from a team as a code owner May 14, 2024 18:43
@StefanVukovic99 StefanVukovic99 added kind/meta The issue or PR is meta area/tech-debt labels May 14, 2024
@@ -4361,5 +4361,51 @@
"url": "<a href=\"url:\">url:</a>"
}
]
},
{
"name": "Test search resolution - word",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you hand-writing these test cases or are these generated?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only translator-test-inputs.json is hand-written, the rest is npm run test:unit:write

@jamesmaa jamesmaa added this pull request to the merge queue May 14, 2024
Merged via the queue into yomidevs:master with commit 7a4b832 May 14, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tech-debt kind/meta The issue or PR is meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0