8000 chore: bump min cmake version to 3.10, update googletest by StackOverflowExcept1on · Pull Request #85 · zyantific/zycore-c · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: bump min cmake version to 3.10, update googletest #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2025
Merged

chore: bump min cmake version to 3.10, update googletest #85

merged 1 commit into from
May 6, 2025

Conversation

StackOverflowExcept1on
Copy link
Contributor

This PR fixes build errors on newer versions of CMake. Since version 3.10 was released in 2018, it makes sense to update to the min version.

build errors (click to expand) 
$ cmake --version
cmake version 4.0.1

$ mkdir -p build && cd build
$ cmake ..
CMake Deprecation Warning at CMakeLists.txt:5 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

-- The C compiler identification is GNU 11.4.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) 
-- Configuring done (0.3s)
-- Generating done (0.0s)
-- Build files have been written to: /tmp/zycore-c/build

$ mkdir -p build && cd build
$ cmake -DZYCORE_BUILD_TESTS=ON ..
CMake Deprecation Warning at CMakeLists.txt:5 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.


-- The C compiler identification is GNU 11.4.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.


-- Configuring incomplete, errors occurred!
CMake Error at CMakeLists.txt:88 (message):
  CMake step for googletest failed: 1


-- Configuring incomplete, errors occurred!

@StackOverflowExcept1on
Copy link
Contributor Author

@athre0z

@StackOverflowExcept1on StackOverflowExcept1on mentioned this pull request May 6, 2025
Merged
@athre0z
Copy link
Member
athre0z commented May 6, 2025

We generally use oldest supported Ubuntu as a landmark for CMake version. Ubuntu 20.04 currently ships CMake 3.16, so bumping to 3.10 is perfectly fine with me.

athre0z
athre0z approved these changes May 6, 2025
View reviewed changes
Copy link
Member
@athre0z athre0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@athre0z athre0z merged commit de93227 into zyantific:master May 6, 2025
48 checks passed
@StackOverflowExcept1on
Copy link
Contributor Author

Thanks for the quick reply, I'll update the dependency here (zyantific/zydis#569) now and we'll continue the same in the main repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@athre0z athre0z athre0z approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StackOverflowExcept1on @athre0z
0