feat: replace Crane usage for Image pull and Push with ORAS #3559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zarf-docs canceled.
|
|
let's gooooooo! so excited for this lol |
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
…3550) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
git push Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
mkcp
previously approved these changes
Mar 29, 2025
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
mkcp
approved these changes
Apr 1, 2025
2 tasks
2 tasks
2 tasks
nevinaragam
pushed a commit
to nevinaragam/zarf
that referenced
this pull request
May 20, 2025
…#3559) Signed-off-by: Austin Abro <AustinAbro321@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: razzle <razzle@defenseunicorns.com> Signed-off-by: NevinAragam <nevin.aragam@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This replaces the Crane library uses for image pulls and pushes with ORAS. This does not change
zarf tools craneoperations.Proposal - ZEP-0019: Refactor Image operations #20
This PR also enables the Zarf cache during E2E tests which helps verify that #3194 is truly getting solved.
Crane has special behavior for localhost. If localhost is used for image pulls or pushes it will try to connect over https, and fallback to http if that fails. This behavior was brought into Zarf since ORAS does not have it.
Release notes:
Image pulls and pushes now respect the
--oci-concurrencyflag to determine the number of layers to pull/push in parallel. In previous versions of Zarf every image layer was pulled and pushed concurrently and the--oci-concurrencyflag only applied tozarf package publishandzarf package pull. Additionally, the default value of--oci-concurrencychanged from three to six.Zarf will no longer pull images in parallel, you may see a slowdown if you have a fast internet connection. We changed this because concurrent image pulls were causing reliability issues for some users. Generally image pulls are bottlenecked by the network so too many concurrent pulls can degrade performance.
The
--plain-httpflag is now respected when connected to registries for image pulls and pushes.Docker v1 images are no longer supported. Dockerhub completely stopped serving v1 images in June 2019, it's unlikely you will be effected by this, but if you are using a particularly old registry you may want to double check.
The format of the cache is changing. You are encouraged to run
zarf tools clear-cacheas existing image layers will not do anything.Related Issue
Fixes #3434
Fixes #3194
Relates to #3113
Relates to #2104
Checklist before merging