refactor: include all workload resources #3640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zarf-docs canceled.
|
add pod, cronjob, and replicationcontroller to minimize usage of standard submatching Signed-off-by: William Crum <will@wcrum.dev>
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Thanks for the changes!
It does improve the output regarding packages that have these resources.
Current output of main with: zarf dev find-images src/test/packages/38-ephemeral-container/
components:
# Possible images - basic-pod - alpine
- ghcr.io/zarf-dev/images/alpine:3.21.3After including these changes:
components:
- name: alpine
images:
- ghcr.io/zarf-dev/images/alpine:3.21.3
nevinaragam
pushed a commit
to nevinaragam/zarf
that referenced
this pull request
May 20, 2025
Signed-off-by: William Crum <will@wcrum.dev> Signed-off-by: NevinAragam <nevin.aragam@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add pod, cronjob, and replicationcontroller to minimize usage of standard submatching
Description
This pull request does not add any features or changes any code flow.
The
processUnstructuredImages()function iterates over resources and passes child PodSpec resources intoappendToImageMap()to grab a list of all required images.While following logic, thought it would be more cohesive to support all resources that include Pod specs, include Pod itself, CronJob and ReplicationController (although legacy).
...
Related Issue
Not related to any existing issues.
Checklist before merging