8000 docs: remove component-choice example by AustinAbro321 · Pull Request #3668 · zarf-dev/zarf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: remove component-choice example #3668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 14, 2025
Merged

Conversation

AustinAbro321
Copy link
Contributor
@AustinAbro321 AustinAbro321 commented Apr 14, 2025

Description

The group key has been deprecated for a long time and will be removed in the next schema version. There's no reason to have docs on how to use it.

Relates to #3433

Checklist before merging

Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 requested review from a team as code owners April 14, 2025 17:55
Copy link
netlify bot commented Apr 14, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 4931cde
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/67fd6267d982c80008fa71f0

Copy link
codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

AustinAbro321 and others 8000 added 3 commits April 14, 2025 18:02
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 changed the title docs: remove example of groups key docs: remove component-choice example Apr 14, 2025
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Copy link
Member
@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Apr 14, 2025
Merged via the queue into main with commit 531daa6 Apr 14, 2025
26 checks passed
@AustinAbro321 AustinAbro321 deleted the remove-group-examples branch April 14, 2025 20:44
nevinaragam pushed a commit to nevinaragam/zarf that referenced this pull request May 20, 2025
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: NevinAragam <nevin.aragam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0